[Feature] 디자인 시스템 기반 컴포넌트 일부 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hin6150
approved these changes
May 18, 2024
hin6150
reviewed
May 19, 2024
Comment on lines
+111
to
+116
| <li> | ||
| <p className="storybook-subtitle">No Blue Line</p> | ||
| <Button {...props} filled={false}> | ||
| {props.children} | ||
| </Button> | ||
| </li> |
There was a problem hiding this comment.
엄청 중요한 부분은 아닌데 작업하면서 보니
<Button {...props} filled={false} blueLine={false}>
으로 작성해야 Story Book에서 blueline이 제거된 상태로 올바르게 표기되더라구요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Overview
@vook-client/ui에서@vook-client/design-system으로 변경sprinkles생성Text컴포넌트 구현Button컴포넌트 구현Additional Comment
Issue
#7
Check List
References